filip/Stalwart
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove StandardOutput, StandardError in service (#390)

Browse Source 
systemd 249 (used in Ubuntu 22.04 LTS) throws the following error:

/etc/systemd/system/stalwart-mail.service:16: Standard output type
syslog is obsolete, automatically updating to journal. Please update
your unit file, and consider removing the setting altogether.

/etc/systemd/system/stalwart-mail.service:17: Standard output type
syslog is obsolete, automatically updating to journal. Please update
your unit file, and consider removing the setting altogether.

This is caused by StandardOutput=syslog and StandardError=syslog found
in install.sh, which are as the error suggests obsolete options that
should not be used.[1] They have "correct" settings in
stalwart-mail.service, but these settings are also the implicit
default, which means they are not necessary.[1]

This was patched in systemd #15812 in May, 2020.[2]

I have tested this by simply removing the values in
/etc/systemd/system/stalwart-mail.service on my server, running
'daemon-reload' and restarting the service, then confirming that logs
are still being written to journalctl as well as /opt/stalwart-mail/logs

[1]: <https://github.com/systemd/systemd/issues/15807#issuecomment-628528787>
[2]: <https://github.com/systemd/systemd/pull/15812>
This commit is contained in:
Linus
2024-05-05 15:59:13 +02:00
committed by GitHub
parent df68ebadf8
commit 0d78f66bcf
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
install.sh
View File

@@ -137,7 +137,7 @@ Description=Stalwart Mail Server Server
Conflicts=postfix.service sendmail.service exim4.service Conflicts=postfix.service sendmail.service exim4.service
ConditionPathExists=__PATH__/etc/config.toml ConditionPathExists=__PATH__/etc/config.toml
After=network-online.target After=network-online.target
[Service] [Service]
Type=simple Type=simple
LimitNOFILE=65536 LimitNOFILE=65536
@@ -147,10 +147,8 @@ Restart=on-failure
RestartSec=5 RestartSec=5
ExecStart=__PATH__/bin/stalwart-mail --config=__PATH__/etc/config.toml ExecStart=__PATH__/bin/stalwart-mail --config=__PATH__/etc/config.toml
PermissionsStartOnly=true PermissionsStartOnly=true
StandardOutput=syslog
StandardError=syslog
SyslogIdentifier=stalwart-mail SyslogIdentifier=stalwart-mail
[Install] [Install]
WantedBy=multi-user.target WantedBy=multi-user.target
EOF EOF

6
resources/systemd/stalwart-mail.service
View File

@@ -3,7 +3,7 @@ Description=Stalwart Mail Server Server
Conflicts=postfix.service sendmail.service exim4.service Conflicts=postfix.service sendmail.service exim4.service
ConditionPathExists=__PATH__/etc/config.toml ConditionPathExists=__PATH__/etc/config.toml
After=network-online.target After=network-online.target
[Service] [Service]
Type=simple Type=simple
LimitNOFILE=65536 LimitNOFILE=65536
@@ -13,9 +13,7 @@ Restart=on-failure
RestartSec=5 RestartSec=5
ExecStart=__PATH__/bin/stalwart-mail --config=__PATH__/etc/config.toml ExecStart=__PATH__/bin/stalwart-mail --config=__PATH__/etc/config.toml
PermissionsStartOnly=true PermissionsStartOnly=true
StandardOutput=journal
StandardError=journal
SyslogIdentifier=stalwart-mail SyslogIdentifier=stalwart-mail
[Install] [Install]
WantedBy=multi-user.target WantedBy=multi-user.target