STARTLS optional fix + Sieve functions

tests/resources/smtp/sieve/functions.sieve

@@ -0,0 +1,24 @@
+require ["variables", "include", "vnd.stalwart.plugins", "reject"];
+
+set "address1" "john@doe.example.org";
+set "address2" "jane@smith.example.org";
+set "address3" "john@example.org";
+set "address4" "jane@example.org";
+set "address5" "john@localhost";
+set "address6" "jane@localhost";
+
+if not string :is "${address1.base_domain()}" "${address2.base_domain()}" {
+    reject "${address1.base_domain()} != ${address2.base_domain()}";
+    stop;
+}
+
+if not string :is "${address3.base_domain()}" "${address4.base_domain()}" {
+    reject "${address3.base_domain()} != ${address4.base_domain()}";
+    stop;
+}
+
+if not string :is "${address5.base_domain()}" "${address6.base_domain()}" {
+    reject "${address5.base_domain()} != ${address6.base_domain()}";
+    stop;
+}
+

tests/src/smtp/outbound/mod.rs

@@ -36,6 +36,7 @@ pub mod lmtp;
 pub mod mta_sts;
 pub mod smtp;
 pub mod throttle;
+pub mod tls;
 
 const SERVER: &str = "
 [server]

tests/src/smtp/outbound/tls.rs

@@ -0,0 +1,107 @@
+/*
+ * Copyright (c) 2023 Stalwart Labs Ltd.
+ *
+ * This file is part of Stalwart Mail Server.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ * in the LICENSE file at the top-level directory of this distribution.
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * You can be released from the requirements of the AGPLv3 license by
+ * purchasing a commercial license. Please contact licensing@stalw.art
+ * for more details.
+*/
+
+use std::{
+    sync::Arc,
+    time::{Duration, Instant},
+};
+
+use mail_auth::MX;
+use utils::config::ServerProtocol;
+
+use crate::smtp::{
+    inbound::{TestMessage, TestQueueEvent},
+    outbound::start_test_server,
+    session::{TestSession, VerifyResponse},
+    TestConfig, TestSMTP,
+};
+use smtp::{
+    config::{IfBlock, RequireOptional},
+    core::{Session, SMTP},
+    queue::{manager::Queue, DeliveryAttempt},
+};
+
+#[tokio::test]
+#[serial_test::serial]
+async fn starttls_optional() {
+    /*tracing::subscriber::set_global_default(
+        tracing_subscriber::FmtSubscriber::builder()
+            .with_max_level(tracing::Level::TRACE)
+            .finish(),
+    )
+    .unwrap();*/
+
+    // Start test server
+    let mut core = SMTP::test();
+    core.session.config.rcpt.relay = IfBlock::new(true);
+    let mut remote_qr = core.init_test_queue("smtp_starttls_remote");
+    let _rx = start_test_server(core.into(), &[ServerProtocol::Smtp]);
+
+    // Add mock DNS entries
+    let mut core = SMTP::test();
+    core.queue.config.hostname = IfBlock::new("badtls.foobar.org".to_string());
+    core.resolvers.dns.mx_add(
+        "foobar.org",
+        vec![MX {
+            exchanges: vec!["mx.foobar.org".to_string()],
+            preference: 10,
+        }],
+        Instant::now() + Duration::from_secs(10),
+    );
+    core.resolvers.dns.ipv4_add(
+        "mx.foobar.org",
+        vec!["127.0.0.1".parse().unwrap()],
+        Instant::now() + Duration::from_secs(10),
+    );
+
+    // Retry on failed STARTTLS
+    let mut local_qr = core.init_test_queue("smtp_starttls_local");
+    core.session.config.rcpt.relay = IfBlock::new(true);
+    core.queue.config.tls.start = IfBlock::new(RequireOptional::Optional);
+
+    let core = Arc::new(core);
+    let mut queue = Queue::default();
+    let mut session = Session::test(core.clone());
+    session.data.remote_ip = "10.0.0.1".parse().unwrap();
+    session.eval_session_params().await;
+    session.ehlo("mx.test.org").await;
+    session
+        .send_message("john@test.org", &["bill@foobar.org"], "test:no_dkim", "250")
+        .await;
+    DeliveryAttempt::from(local_qr.read_event().await.unwrap_message())
+        .try_deliver(core.clone(), &mut queue)
+        .await;
+    let mut retry = local_qr.read_event().await.unwrap_retry();
+    assert!(retry.inner.domains[0].disable_tls);
+    retry.inner.domains[0].retry.due = Instant::now();
+    DeliveryAttempt::from(retry.inner)
+        .try_deliver(core.clone(), &mut queue)
+        .await;
+    local_qr.read_event().await.unwrap_done();
+    remote_qr
+        .read_event()
+        .await
+        .unwrap_message()
+        .read_lines()
+        .assert_not_contains("using TLSv1.3 with cipher");
+}