Fix JMAP: filter: null rejected as notRequest on /query and /queryChanges

CHANGELOG.md

@@ -17,7 +17,8 @@ If you are upgrading from v0.16.x, replace the binary (or run `docker pull`). If
 ## Fixed
 - JMAP:
   - Default calendars and address books are not subscribed by default.
-  - Do not reject an unchanged immutable `id` property.
+  - Unchanged immutable `id` property is rejected on `/set`.
+  - `filter: null` rejected as `notRequest` on `/query` and `/queryChanges`.
 - OIDC: Add default domain name to groups that are not email addresses.
 - RocksDB: Enable blob garbage collection to reclaim disk space from deleted blobs.
 

crates/jmap-proto/src/method/query.rs

@@ -195,6 +195,20 @@ where
                 write!(formatter, "a filter object")
             }
 
+            fn visit_unit<E>(self) -> Result<(), E>
+            where
+                E: de::Error,
+            {
+                Ok(())
+            }
+
+            fn visit_none<E>(self) -> Result<(), E>
+            where
+                E: de::Error,
+            {
+                Ok(())
+            }
+
             fn visit_map<V>(self, mut map: V) -> Result<(), V::Error>
             where
                 V: MapAccess<'de>,
@@ -261,7 +275,7 @@ where
             }
         }
 
-        deserializer.deserialize_map(FilterVisitor(self.0))
+        deserializer.deserialize_any(FilterVisitor(self.0))
     }
 }